Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow redirecting to the same URL when referrer is overwritten #754

Merged
merged 1 commit into from
Oct 28, 2018
Merged

Allow redirecting to the same URL when referrer is overwritten #754

merged 1 commit into from
Oct 28, 2018

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 28, 2018

Fix brave/brave-browser#1861, document.referrer is not updated because we start to block same url redirection in 394753b.
This PR fixes BraveContentSettingsObserverBrowserTest.BlockReferrer, BraveContentSettingsObserverBrowserTest.BlockReferrerByDefault, and HTTPSEverywhereServiceTest.RedirectsKnownSiteInIframe.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

npm test brave_browser_tests

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@yrliou yrliou self-assigned this Oct 28, 2018
@yrliou yrliou requested a review from bbondy October 28, 2018 20:11
bbondy
bbondy approved these changes Oct 28, 2018
View reviewed changes
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bbondy bbondy merged commit a88e5e0 into master Oct 28, 2018
bbondy added a commit that referenced this pull request Oct 28, 2018
@bbondy
Merge pull request #754 from brave/fix_referrer_and_httpse
84dee7f 
Allow redirecting to the same URL when referrer is overwritten
bbondy added a commit that referenced this pull request Oct 28, 2018
@bbondy
Merge pull request #754 from brave/fix_referrer_and_httpse
10c4b86 
Allow redirecting to the same URL when referrer is overwritten
@bbondy
Copy link
Member

bbondy commented Oct 28, 2018

master: a88e5e0
0.57.x: 84dee7f
0.56.x: 10c4b86

@yrliou yrliou deleted the fix_referrer_and_httpse branch October 28, 2018 20:52
@bbondy bbondy added this to the 0.56.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
0.56.x - Release
Development

Successfully merging this pull request may close these issues.

document.referer leaks the referrer
2 participants
@yrliou @bbondy